Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph ambiguity given multiple rules with the same intermediate path #9320

Closed
Eric-Arellano opened this issue Mar 17, 2020 · 2 comments
Closed

Comments

@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Mar 17, 2020

We would expect this to work:

X -> Z
A -> X -> Z
B -> X -> Z

But, it fails due to multiple ways to compute await Get[Z](X).

Specifically, this is causing graph ambiguity:

StripSnapshotRequest -> SourceRootStrippedSources
StripSourcesFieldRequest -> StripSnapshotRequest -> SourceRootStrippedSources
LegacyStripTargetRequest -> StripSnapshotRequest -> SourceRootStrippedSources

Refer to https://pantsbuild.slack.com/archives/C0D7TNJHL/p1584460732313100.

--

This works as a workaround:

X -> Z
A -> X -> Z
B -> X -> Z -> M

where M is a new type.

@stuhood
Copy link
Member

stuhood commented Apr 24, 2020

The example in the description doesn't quite make sense to me... it seems like that should work just fine, so grabbing out a failing testcase next time someone encounters this would be helpful.

But I expect that either way this relates to #7710.

@Eric-Arellano
Copy link
Contributor Author

I believe this was fixed by the new graph algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants