Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/python/pants_test/pantsd:pailgun_server is flaky #8206

Closed
stuhood opened this issue Aug 24, 2019 · 2 comments · Fixed by #9722
Closed

tests/python/pants_test/pantsd:pailgun_server is flaky #8206

stuhood opened this issue Aug 24, 2019 · 2 comments · Fixed by #9722
Labels
flaky-test

Comments

@stuhood
Copy link
Member

stuhood commented Aug 24, 2019

This occasionally times out on the unit tests shard after having run for 900 seconds (ie, it hangs).
@Eric-Arellano
Copy link
Contributor

If anyone takes this PR up, the first step I recommend is to split out each individual test into its own Pants target. Then, modify .travis.yml to only run those tests and use a script to keep doing it until failure. See #8588 for how I did this with the exception sink integration test.

This will allow us to isolate which individual tests are hanging.

@stuhood
Copy link
Member Author

stuhood commented Nov 22, 2019

Seen again in master.

@jsirois jsirois self-assigned this Mar 24, 2020
@jsirois jsirois removed their assignment Mar 25, 2020
@stuhood stuhood mentioned this issue May 10, 2020
Merged
stuhood pushed a commit that referenced this issue May 13, 2020
Port the pantsd nailgun server to rust (#9722)
9506fbf 
### Problem

The setup and teardown of each request made to the nailgun server in `pantsd` had become quite complicated over time... and consequently, slower than it needed to be.

### Solution

Port `pantsd`'s nailgun server to rust using the `nails` crate. Additionally, remove the `Exiter` class, which had accumulated excess responsibilities that can instead be handled by returning `ExitCode` values. Finally, fix a few broken windows including: double logging to pantsd, double help output, closed file errors on pantsd shutdown, and redundant setup codepaths.

### Result

There is less code to maintain, and runs of `./pants --enable-pantsd help` take `~1.7s`, of which `~400ms` are spent in the server. Fixes #9448, fixes #8243, fixes #8206, fixes #8127, fixes #7653, fixes #7613, fixes #7597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Port the pantsd nailgun server to rust stuhood/pants
3 participants
@stuhood @jsirois @Eric-Arellano