-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky product graph construction: Invalid requirement, parse error at "u''" #6861
Comments
Noting that the linked log does not correspond to the pasted error. The pasted error happens before any test runs during the build graph setup for the whole pants run of:
This would seem to point not to a flaky test, but a flaky bit of the production system which is perhaps more alarming. Re-labeling as a bug. |
The actual underlying exception stacktrace is hidden by the raised |
Seen again in master. Related to the dumb repro attempt: it's possible that wrapping-and-re-raising as |
This is happening to us as well, and seems to be more common in the recent weeks (3 in the last 7 days, which is why I started paying attention), though I don't have more specific statistics. Have yet to find a pattern on which commands cause them (the last three that I saw were |
If this is something that can be reliably recognized in some way (we can do some hacky thing looking at the exception message), we could consider adding an option to either provide a specific error message saying "THIS IS A FLAKY ERROR, SEE #6861", or to automatically restart after dumping a lot of warnings (and only retry once, probably). |
Hm... have we had a recent repro of this one? Wondering whether #7379 was related somehow. |
I don't think I've seen this recently, but I'm not sure how long it's been since I last saw this, probably a week or two? edit: derp we haven't changed anything regarding pants versions on our side so I'm not sure why I thought anything is supposed to be different. Saw it again today but it is interesting that there were days where it happens a lot and days where it just doesn't. |
Is it fixed in recent versions? I hit this issue in 0.14.0 |
Seen on master on 5/21/2019 in 'Unit tests (Py2.7 PEX)' shard:
|
Seen in PR #7804 on 5/26/2019 in job: https://travis-ci.org/pantsbuild/pants/jobs/537577092 |
@yaup @haneul could you both please check if your Twitter removed their |
@Eric-Arellano we don't have any plugins installed via the |
@yaup also, what Pants version are you using? Are you using the Another way to check this is if you have ever seen the error without |
@Eric-Arellano We are using pants 1.14. I haven't updated the I don't recall seeing just |
Thanks for the quick response! That means that, yes, you are running Pants with Python 2. I suspect this won't be an issue once you upgrade to >= 1.15.0 and upgrade the |
Hmmm I see. I had 1.15 upgrades in the pipelines when I handed this work off recently, so I suppose we'll see how that goes. Thanks! |
As a temporary workaround, I believe that you can add |
Hmm... no repros in a long while on this one (in CI at least). |
We haven't seen this in several months. It seems this was from Python 2, and possibly when you did not have |
https://api.travis-ci.org/v3/job/463150773/log.txt
The text was updated successfully, but these errors were encountered: