Port IsolatedProcess implementation to rust, and align with bazel remoting API #4397
Assignees
Comments
stuhood
changed the title
|
Assigning to @illicitonion : thanks! |
This was referenced Nov 15, 2017
ity
added a commit
that referenced
this issue
Jan 20, 2018
) * Port IsolatedProcess implementation from Python to Rust - Part 1 Problem From #4397 - Isolated processes currently work for the purposes of testing, but there are lots of abstraction leaks: in particular, a _Snapshots snapshots object is exposed which the python code uses to reverse engineer the location of snapshots. Instead, process execution should be ported to rust (maybe using duct?) to remove that leak. Additionally, the outcome of discussion around https://docs.google.com/document/d/1jGq34ds_fhRLPDnmHNV_FHcJiJnbhmk2XEwOf9-w5To/edit#heading=h.ylneg9wnwxcs was that we should adapt the process execution model (which is implicitly also a "remote process execution" model) more closely with the draft of bazel's process execution model. Solution This is the first split of the bigger branch (master...ity:ity/cloc_rules) that ports the implementation to Rust. This PR can go in independently and will make it easier to work with smaller branches. Changes made in this PR: Invoke process execution in Rust from Python Plumbing for ExecuteProcessRequest/ExecuteProcessResult cloc can be invoked from commandline which invokes Rust process execution Test (test_javac_version_example) added in python which invokes Rust through Rules. Removed directories_to_create after discussing with @illicitonion
stuhood
pushed a commit
that referenced
this issue
Jan 24, 2018
) * Port IsolatedProcess implementation from Python to Rust - Part 1 Problem From #4397 - Isolated processes currently work for the purposes of testing, but there are lots of abstraction leaks: in particular, a _Snapshots snapshots object is exposed which the python code uses to reverse engineer the location of snapshots. Instead, process execution should be ported to rust (maybe using duct?) to remove that leak. Additionally, the outcome of discussion around https://docs.google.com/document/d/1jGq34ds_fhRLPDnmHNV_FHcJiJnbhmk2XEwOf9-w5To/edit#heading=h.ylneg9wnwxcs was that we should adapt the process execution model (which is implicitly also a "remote process execution" model) more closely with the draft of bazel's process execution model. Solution This is the first split of the bigger branch (master...ity:ity/cloc_rules) that ports the implementation to Rust. This PR can go in independently and will make it easier to work with smaller branches. Changes made in this PR: Invoke process execution in Rust from Python Plumbing for ExecuteProcessRequest/ExecuteProcessResult cloc can be invoked from commandline which invokes Rust process execution Test (test_javac_version_example) added in python which invokes Rust through Rules. Removed directories_to_create after discussing with @illicitonion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Isolated processes currently work for the purposes of testing, but there are lots of abstraction leaks: in particular, a
_Snapshotssnapshots object is exposed which the python code uses to reverse engineer the location of snapshots.Instead, process execution should be ported to rust (maybe using duct?) to remove that leak.
Additionally, the outcome of discussion around https://docs.google.com/document/d/1jGq34ds_fhRLPDnmHNV_FHcJiJnbhmk2XEwOf9-w5To/edit#heading=h.ylneg9wnwxcs was that we should adapt the process execution model (which is implicitly also a "remote process execution" model) more closely with the draft of bazel's process execution model.
The text was updated successfully, but these errors were encountered: