Link requirements targets to their source. (#6405)

Previously the `python_requirements` macro would not link the `PythonRequirementLibrary` targets it generated from a requirements file to the requirement file itself, leading to invalidation bugs. We now do this by adding a dependency on the requirements file to each `PythonRequirementLibrary` generated. Fixes #6404
pantsbuild · Aug 28, 2018 · f8020c6 · f8020c6
1 parent 58a6245
commit f8020c6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/3rdparty/python/BUILD b/3rdparty/python/BUILD
@@ -25,9 +25,3 @@ python_requirement_library(
     python_requirement('s3-log-parse==0.1.1')
   ]
 )
-
-# NB: Needed only for tests: tests/python/pants_test/engine/legacy:graph.
-files(
-  name='requirements_files',
-  sources=rglobs('**/requirements.txt'),
-)
diff --git a/src/python/pants/backend/python/python_requirements.py b/src/python/pants/backend/python/python_requirements.py
@@ -58,9 +58,16 @@ def __call__(self, requirements_relpath='requirements.txt'):
                   raise ValueError('Only 1 --find-links url is supported per requirements file')
                 repository = value
 
+    requirements_file_target_name = requirements_relpath
+    self._parse_context.create_object('files',
+                                      name=requirements_file_target_name,
+                                      sources=[requirements_relpath])
+    requirements_dep = ':{}'.format(requirements_file_target_name)
+
     for requirement in requirements:
       req = self._parse_context.create_object('python_requirement', requirement,
                                               repository=repository)
       self._parse_context.create_object('python_requirement_library',
                                         name=req.project_name,
-                                        requirements=[req])
+                                        requirements=[req],
+                                        dependencies=[requirements_dep])
diff --git a/tests/python/pants_test/engine/legacy/BUILD b/tests/python/pants_test/engine/legacy/BUILD
@@ -108,7 +108,6 @@ python_tests(
   sources = ['test_graph.py'],
   dependencies = [
     '3rdparty/python:mock',
-    '3rdparty/python:requirements_files',
     'src/python/pants/bin',
     'src/python/pants/build_graph',
     'src/python/pants/engine/legacy:graph',