Skip to content

Commit

Permalink
Fix bad tuple type hints
Browse files Browse the repository at this point in the history
  • Loading branch information
Eric-Arellano committed Oct 9, 2019
1 parent ef9693d commit a97122f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions src/python/pants/engine/fs.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ class PathGlobs:
NB: this object is interpreted from within Snapshot::lift_path_globs() -- that method will need to
be aware of any changes to this object's definition.
"""
include: Tuple[str]
exclude: Tuple[str]
include: Tuple[str, ...]
exclude: Tuple[str, ...]
glob_match_error_behavior: GlobMatchErrorBehavior
conjunction: GlobExpansionConjunction

Expand Down Expand Up @@ -138,8 +138,8 @@ class Snapshot:
sandboxes.
"""
directory_digest: Digest
files: Tuple[str]
dirs: Tuple[str]
files: Tuple[str, ...]
dirs: Tuple[str, ...]

@property
def is_empty(self):
Expand Down
2 changes: 1 addition & 1 deletion src/python/pants/engine/selectors.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class Params:
Distinct types are enforced at consumption time by the rust type of the same name.
"""
params: Tuple[Any]
params: Tuple[Any, ...]

def __init__(self, *args: Any) -> None:
self.params = tuple(args)
2 changes: 1 addition & 1 deletion tests/python/pants_test/engine/test_isolated_process.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class JavacSources:
See CatExecutionRequest and rules above for an example of using PathGlobs
which does not introduce this additional layer of indirection.
"""
java_files: Tuple[str]
java_files: Tuple[str, ...]


@dataclass(frozen=True)
Expand Down

0 comments on commit a97122f

Please sign in to comment.