Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove unnecessary
WrappedNode
method indirection (#15813)
The `WrappedNode::run_wrapped_node` method was never actually called "via" `trait WrappedNode`, because it was only called immediately after matching a particular `NodeKey` implementation. So having the method was a bit misleading, but it also meant that: 1. all node implementations needed to have the same shape for their implementation method * 9 out of 11 of them had an unused parameter. * #11331 will be introducing another parameter for the `ExecuteProcess` node, which would have been unused for 10/11 nodes 2. `run_wrapped_node` was unnecessarily boxed due to `WrappedNode` needing to be marked `async_trait`. Removing the boxing means one fewer allocation per node. This change removes `WrappedNode::run_wrapped_node`, and replaces it with a convention of having a `run_node` method. [ci skip-build-wheels]
- Loading branch information