Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tuning] EC2 Download Instance User Data #1498

Merged
merged 3 commits into from
Feb 3, 2025
Merged

[Tuning] EC2 Download Instance User Data #1498

merged 3 commits into from
Feb 3, 2025

Conversation

arielkr256
Copy link
Contributor

Background

AWS.EC2.DownloadInstanceUserData was generating a high number of alerts in our test environment due to incorrect deduping and short dedup period.

Changes

  • Dedup on actor_user and accountId instead of principalId
  • Increase threshold from 5 to 10
  • Increase dedup period from 1 hour to 24 hours

Testing

  • pat test

@arielkr256 arielkr256 requested a review from a team as a code owner January 30, 2025 16:41
@arielkr256 arielkr256 added the tuning detection tuning label Jan 30, 2025
@arielkr256 arielkr256 enabled auto-merge February 3, 2025 16:04
@arielkr256 arielkr256 added this pull request to the merge queue Feb 3, 2025
Merged via the queue into develop with commit 06ddb09 Feb 3, 2025
6 checks passed
@arielkr256 arielkr256 deleted the tuning-ec2downloadinstancedata branch February 3, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le4ker le4ker le4ker approved these changes

Assignees
No one assigned
Labels
tuning detection tuning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielkr256 @le4ker