Use in_array in wp_cache_supports #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Viktor, thanks for the PR. We copied the function added in #378 from WordPress core. Is there a performance benefit possible with this change? |
|
@CdrMarks All right. I'm not willing to push my agenda. BTW all code ending in return true/false shows a developer not understanding booleans |
|
I'm sorry. I am used to "Thank you, Viktor" + merge. |
Correct; he's no longer working on Pantheon's plugins. I'm going to close this for now. Do let us know if you see any other issues. |
|
@CdrMarks 6 years of contribution has to stop. It is very sad. |
@ szepeviktor Yes it’s sad Daniel’s gone, but Pantheon now has a team dedicated to maintaining these plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #378