[CMSP-470] Replace use of wp_strip_all_tags (possibly any wp filter function?) in object-cache.php #432
Labels
Comments
pwtyler
changed the title
timnolte
added a commit
to timnolte/wp-redis
that referenced
this issue
Jun 21, 2023
…er issues * Fixes pantheon-systems#433 * Fixes pantheon-systems#432 * Fixes pantheon-systems#431 * Further clean-up & standardization between object-cache.php & wp-redis.php. * Fixes incorrect order of array_replace_recursive arguments. * Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.
Closed
jazzsequence
pushed a commit
to timnolte/wp-redis
that referenced
this issue
Jun 23, 2023
…er issues * Fixes pantheon-systems#433 * Fixes pantheon-systems#432 * Fixes pantheon-systems#431 * Further clean-up & standardization between object-cache.php & wp-redis.php. * Fixes incorrect order of array_replace_recursive arguments. * Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.
jazzsequence
added a commit
that referenced
this issue
Jun 26, 2023
…er issues (#434) * fix: Fixes incorrect order of array_replace_recursive arguments & other issues * Fixes #433 * Fixes #432 * Fixes #431 * Further clean-up & standardization between object-cache.php & wp-redis.php. * Fixes incorrect order of array_replace_recursive arguments. * Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use. * fix: Fixes sanitization methods and linting issues * Adjusts some items to use type-based sanitization. * Adds linting expection handling with comments for cases that require it. * fix: Removes invalid change made in #437 * Reverts this incorrect change that was made due to the incorrect use of `array_replace_recursive()`. * update changelog * Update wp-redis.php * update language in changelogs * fix missing closing ) --------- Co-authored-by: Chris Reynolds <chris@jazzsequence.com> Co-authored-by: Phil Tyler <philip@tylerdigital.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From WordPress.org support (cc @mdifelice)
Fatal error when combining with full-page cache
Since version 1.4.2 (at least that I am aware of), the method build_client_parameters included in the object-cache.php has been modified to escape the server configuration variables using the function wp_strip_all_tags.
If this plugin is used in conjunction with the WordPress full-page cache functionality it throws a fatal error. The reason is that in order to activate that functionality WordPress includes the file advanced-cache.php before the file wp-includes/formatting.php is included (which is in charge of defining wp_strip_all_tags). If advanced-cache.php uses object caching it must include object-cache.php but when executing the mentioned method a fatal error is raised. And if formatting.php is included or the missing function is defined somehow before it is called, a fatal error will be raised later because of a duplicate definition.
I would like to know if this is something you plan to fix in an upcoming version because, if you do not, I would need to replace the plugin. I think that probably what you want to achieve with that change can be easily achieved with a built-in PHP function, as strip_tags maybe.
Another regression/bug introduced with #400.
Also tagging as related (as also affected by
wp_strip_all_tags) #431The text was updated successfully, but these errors were encountered: