[CMS-1078] Tweak tests a bit. #465
Conversation
kporras07
commented
Oct 17, 2022
•
kporras07
commented
- Re-add image replacement script that is actually still needed.
kporras07
changed the title
|
|
||
| # Replace with right docker image. | ||
| cd $TARGET_REPO_WORKING_COPY | ||
| sed -i 's/quay.io\/pantheon\-public\/build\-tools\-ci:6.x/pantheonpublic\/build\-tools\-ci:8.x\-php7.4/g' ./.circleci/config.yml |
There was a problem hiding this comment.
Do we need to do this because there are other contexts where the fixture needs to use the 6.x version? If not, why not just update the fixture?
There was a problem hiding this comment.
hmmm that's a good point. This is for WP-only (iirc); I guess I could just change it there if that makes sense
There was a problem hiding this comment.
@greg-1-anderson just double checking. This won't be in a fixture, it's the wordpress template project. I still think it should be ok to move it to 8.x-php7.4, just double checking. Please confirm
There was a problem hiding this comment.
Doing this seems to actually break the behat_tests over there so, with that and having in mind that we have wordpress-composer-managed in the near(ish) future then I'd like to keep it here at least as of now. @greg-1-anderson any objections?
This reverts commit 51e79e3.
