Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGS-5353] Avoid adding json param if GET request. #462

Merged
merged 1 commit into from
Sep 28, 2022
Merged

[BUGS-5353] Avoid adding json param if GET request. #462

merged 1 commit into from
Sep 28, 2022

Conversation

kporras07
Copy link
Collaborator

@kporras07 kporras07 commented Sep 27, 2022 •
edited
Loading

Previously it was ignored, now it fails the request with 403.

Fixes #461

@kporras07 kporras07 requested a review from a team as a code owner September 27, 2022 22:36
@kporras07 kporras07 changed the title Avoid adding json param if GET request. [BUGS-5353] Avoid adding json param if GET request. Sep 27, 2022
@jspellman814
Copy link
Contributor

@kporras07 Any idea why the tests are failing? Looks like they haven't passed in a while: https://app.circleci.com/pipelines/github/pantheon-systems/terminus-build-tools-plugin

Unless we want to try to fix those as part of this, I'm inclined to approve.

greg-1-anderson
greg-1-anderson approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests pass, must be pretty good. :) Should look into failing tests at some point.

@kporras07 kporras07 merged commit 66d2e7d into 3.x Sep 28, 2022
@kporras07 kporras07 deleted the 461-no-json-in-get branch September 28, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-1-anderson greg-1-anderson greg-1-anderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircleCI API Authentication Fails
3 participants
@kporras07 @jspellman814 @greg-1-anderson