Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated trim() messages when using PHP 8.1 #458

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Fix deprecated trim() messages when using PHP 8.1 #458

merged 1 commit into from
Aug 9, 2022

Conversation

vinmassaro
Copy link
Contributor

Running build:project:create using PHP 8.1, shows deprecated messages like:

PHP Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/vincentmassaro/.terminus/terminus-dependencies-4f7bf5e1bb/vendor/pantheon-systems/terminus-build-tools-plugin/src/Credentials/CredentialManager.php on line 128

This commit fixes these instances of trim() in src/Credentials/CredentialManager.php so it doesn't receive a null value. Thanks.

@vinmassaro vinmassaro requested a review from a team as a code owner August 9, 2022 15:19
@greg-1-anderson
Copy link
Member

Thanks!

@greg-1-anderson greg-1-anderson merged commit d5f15e5 into pantheon-systems:3.x Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants