Clean up peer dependency warnings and latest audit #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add relevant peer dependencies - Ignore irrelevant peer dependency warnings - Add pnpm audit --fix manually to fix failing CI since there is not yet a new version for dicer, use the current version. - Clean up tailwind warnings from gatsby-wordpress-starter
…pendency-management
|
backlineint
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were made?
Our audit script has been failing since the override that was being added does not exist. Until dicer or Gatsby which is the only of
dicerthat we have we will continue using0.2.5. See mscdex/dicer#22 for more info on the dicer update.Other changes made:
react&react-domto17.0.2until we decide to upgrade to v18pnpm audit --fixthat were not being applied in CI due to the dicer versionWhere were the changes made?
pretty much everywhere, but there should be no breaking changes from this.
How have the changes been tested?
Tested every starter locally.
Tested every package locally.
Additional information
This should lead to less scary output from the terminal when setting up the monorepo for the first time.
Note: Keep an eye on
dicerand update the override when the new version is released. Our CI script may do this for us, but since we already have an override I'm not certian.Also there are some deprecated packages still in use, most of them by our docs aka
webworkspace, but there are some coming fromgatsbywhich I would love to fix at some point!Don't forget to add a changeset if needed!