feat: add dark mode #76
Conversation
sametpalitci
force-pushed
the
feat/add-dark-mode
branch
from
4716880 to
895a682
Compare
| <div> | ||
| <div class="ml-4"> | ||
| <h3 class="mb-2 text-2xl font-normal" id="input-types">Input Types</h3> | ||
| <h3 class="mb-2 text-2xl font-normal" id="input-types dark:text-white">Input Types</h3> |
There was a problem hiding this comment.
Please do the same for output types on line 94. Right now it is of wrong color in dark mode
src/printer/index.ts
Outdated
| <body class="bg-gray-200 dark:bg-black"> | ||
| <div class="flex min-h-screen"> | ||
| <div | ||
| class="sticky top-0 w-1/5 flex-shrink-0 h-screen p-4 px-6 mr-4 overflow-auto bg-white mac-h-screen" | ||
| class="sticky top-0 w-1/5 flex-shrink-0 h-screen p-4 px-6 overflow-auto bg-white dark:bg-black mac-h-screen" |
There was a problem hiding this comment.
I would like to have same bg color for sidebar and content so match them to gray-800
There was a problem hiding this comment.
Thanks for the work! I have requested a few small changes then it should be good.
Also, please update the snapshots once after you have made the changes using npm run test -- -u. Right now CI is failing because of that.
Finally you can also maybe look into the code block sections and update those with dark theme using something like https://github.com/antfu/prism-theme-vars. That would be the final touch. You can also do a separate PR for that if you don't have enough time.
|
I've made the requested changes and updated the snapshot. I'm considering maybe making the Prism theme in another pull request at a later time. Thank you. |
Dark Mode:
Light Mode:
