Avoid overwriting attributes on different classes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have the same attribute name in two classes, and it's marked as an attr_(class|symbol) in one of the classes, this helper currently sets the attribute as a symbol in both classes. This leads to unexpected behavior and should be fixed.
|
Small comment: could you preserve the comment about why we need to use |
|
This change makes it so this module doesn't have to be prepended anymore. On Mon, Dec 28, 2015, 8:09 AM Jacob Evelyn notifications@github.com wrote:
|
|
Yep exactly. It would also be nice, come to think of it, for an explanation of why we need to |
|
Updated |
|
Thanks for the changes, and I like the cleanup. This LGTM if tests pass. |
seckenrode
added a commit
that referenced
this pull request
Dec 28, 2015
Avoid overwriting attributes on different classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have the same attribute name in two classes, and it's marked as
an attr_(class|symbol) in one of the classes, this helper currently
sets the attribute as a symbol in both classes.
This leads to unexpected behavior and should be fixed.
@JacobEvelyn