Make changes for ActiveRecord #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this merges I'll yank the version from RubyGems and push the new version. |
|
Just a friendly nudge that this needs review, @radhikamalik. We can't use this in our code until this goes through. |
|
Whoops, sorry about that. Reviewing now. Can we create JIRA tasks for this repo too so we don't lose task tracking? :) |
|
I'm a little wary of duplicating all GitHub issues in JIRA because I think they'll quickly get out of sync. But I'm not strongly against it; let's bring this up in standup on Monday. |
|
Back to you! |
|
LGTM |
JacobEvelyn
force-pushed
the
feature/active-recorder
branch
from
0d6381c to
8646df5
Compare
JacobEvelyn
added a commit
that referenced
this pull request
Jan 12, 2015
Make changes for ActiveRecord
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out a way to make it work with ActiveRecord and generic Ruby classes alike! The downside is there's some complex metaprogramming but fortunately it's isolated and won't affect anything adversely.