-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass kwargs through to pruned FilePatterns #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround here.
Your inline comment suggests to me that we need to tweak our fixtures a little bit.
Looks like you still haven't set up pre-commit hooks for git? Otherwise it would not be possible for you to push a commit that fails pre-commit. |
🤦 I have, but looks like I have to |
No. I definitely don't have to do that. You should only have to install once per environment. |
Oh I think I realize what happened ... I made a new clone of |
@sharkinsspatial, I believe this closes #207.
Maybe it's worth running a
/run-recipe-test
for the recipe described in that Issue to be sure? I'm pretty confident the tests added here now cover that bug, but running this against the real world Issue would certainly be a good gut check, if it's not too hard for you to do.