Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass kwargs through to pruned FilePatterns #215

Merged
merged 9 commits into from
Oct 2, 2021

Conversation

cisaacstern
Copy link
Member

@sharkinsspatial, I believe this closes #207.

Maybe it's worth running a /run-recipe-test for the recipe described in that Issue to be sure? I'm pretty confident the tests added here now cover that bug, but running this against the real world Issue would certainly be a good gut check, if it's not too hard for you to do.

Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround here.

Your inline comment suggests to me that we need to tweak our fixtures a little bit.

pangeo_forge_recipes/patterns.py Outdated Show resolved Hide resolved
tests/test_patterns.py Outdated Show resolved Hide resolved
pangeo_forge_recipes/patterns.py Outdated Show resolved Hide resolved
tests/test_patterns.py Show resolved Hide resolved
tests/test_patterns.py Show resolved Hide resolved
@rabernat
Copy link
Contributor

Looks like you still haven't set up pre-commit hooks for git? Otherwise it would not be possible for you to push a commit that fails pre-commit.

@cisaacstern
Copy link
Member Author

🤦 I have, but looks like I have to pre-commit install every time I activate my conda development environment? I don't always remember to do this and haven't gotten in the habit of looking for the pre-commit run after every commit... so this one slipped through the cracks

@rabernat
Copy link
Contributor

but looks like I have to pre-commit install every time I activate my conda development environment?

No. I definitely don't have to do that. You should only have to install once per environment.

@cisaacstern
Copy link
Member Author

You should only have to install once per environment.

Oh I think I realize what happened ... I made a new clone of pangeo-forge-recipes before working on this branch (had a lot of branches in various states that I didn't need, and re-cloning seemed easier than cleaning up my local copy), so the pre-commit was not in .git/hooks/pre-commit

@rabernat rabernat merged commit e706a66 into pangeo-forge:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.6.0 release causes authentication issue with fsspec_open_kwargs used in FilePattern
2 participants