try importing esmpy (aliased to ESMF) for esmpy >= 8.4.0 fixes #212 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fall back on old name if the import fails
for more information, see https://pre-commit.ci
aulemahal
reviewed
Dec 14, 2022
|
@aulemahal I'm getting the test failing for the spatialAverager with can you take a look? |
|
That's shapely 2.0... ugh... Pinning it to |
|
ok I'll put a pin for now before we get flooded with broken installs with the new esmpy |
raphaeldussin
changed the title
|
fixes #212 this is ready for review (then squash and merge) and somewhat time sensitive. |
aulemahal
approved these changes
Dec 14, 2022
huard
approved these changes
Dec 14, 2022
|
Just add a note to CHANGES about this. |
zmoon
reviewed
Dec 19, 2022
| @@ -14,6 +14,6 @@ dependencies: | |||
| - pydap | |||
| - pytest | |||
| - pytest-cov | |||
| - shapely | |||
| - shapely<2.0 | |||
There was a problem hiding this comment.
Should this have been done in the cf feedstock as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fall back on old name if the import fails