Fix dependencies - sparse and numba #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158
I tried sparse 0.7.0, 0.8.0, 0.9.1 and 0.10.0 (current is 0.13.0) and only 0.7.0 made the test suite fail. I thus assumed the minimum version to be 0.8.0.
Our explicit use of
numba
is very superficial, I didn't really check what the minimum version would be. We could simplify the code by pinning 0.55, but that's the last minor version, it felt too soon to pin only to remove half a line.I also updated the pre-commit hooks (there was a bug with my version of black).