-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable JupterLab=1: noasync dask labextension branch #60
Conversation
This reverts commit 764189f.
@scottyhq is there an easy way to test this out before merging? I suppose you need a docker image to point to in your config, right? |
I think it would be useful to add a 'staging' branch to this repo as we now do with pangeo-cloud-federation. It would help for basic manual tests like we're currently to just make sure the core packages can be imported and clusters launched. thoughts @jhamman ? Other approaches are to run repo2docker locally and push an image to dockerhub, or just point pangeo binder to a similar config (it might be easy to get confused with different repo2docker versions though)... more sophisticated automated testing has come up a few times recently: pangeo-data/pangeo#544 https://discourse.jupyter.org/t/testing-notebooks/701/17 thoughts @jhamman ? |
The downside there is forgetting to sync staging & prod :) It'd be nice if we could upload the built image from CI somewhere (not https://hub.docker.com/u/pangeo, in case someone came along with a malicious PR), but perhaps another organization. That may be more work than it's worth though. Downstream users may want to be pinning the version they're using. |
true, maybe rather than a separate branch we just go ahead and upload/overwrite the latest PR build to (pangeo/staging:latest) or (pangeo/staging:[branch-name]) with no intention of syncing. we could then just point a binder link to this dockerhub tag for testing. I guess the security concern is there, but we could just say in the github readme or dockerhub that these staging images are for testing only and shouldn't be used elsewhere? |
@TomAugspurger per ian's comment here: #50 (comment) If you change your config to match https://github.com/scottyhq/pangeo-binder-test/tree/jlab1 we should go ahead and merge this I think |
Agreed that using that branch makes sense for now. I'm keeping an eye on the changes to dask-kubernetes and distributed. I'll update when this is no longer necessary. |
Thanks. All green now. |
Closes #50
#50 (comment) (maybe fixes it).