Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JupterLab=1: noasync dask labextension branch #60

Merged
merged 10 commits into from
Jul 30, 2019

Conversation

TomAugspurger
Copy link
Member

@TomAugspurger TomAugspurger commented Jul 22, 2019

Closes #50

#50 (comment) (maybe fixes it).

@TomAugspurger TomAugspurger changed the title Pin tornado to 5.x Change to jupyter-server-proxy Jul 22, 2019
@TomAugspurger
Copy link
Member Author

@scottyhq is there an easy way to test this out before merging? I suppose you need a docker image to point to in your config, right?

@scottyhq
Copy link
Member

I think it would be useful to add a 'staging' branch to this repo as we now do with pangeo-cloud-federation. It would help for basic manual tests like we're currently to just make sure the core packages can be imported and clusters launched. thoughts @jhamman ?

Other approaches are to run repo2docker locally and push an image to dockerhub, or just point pangeo binder to a similar config (it might be easy to get confused with different repo2docker versions though)...
for this case:
https://github.com/scottyhq/pangeo-binder-test/tree/jlab1

more sophisticated automated testing has come up a few times recently: pangeo-data/pangeo#544 https://discourse.jupyter.org/t/testing-notebooks/701/17

thoughts @jhamman ?

@TomAugspurger
Copy link
Member Author

TomAugspurger commented Jul 22, 2019

The downside there is forgetting to sync staging & prod :)

It'd be nice if we could upload the built image from CI somewhere (not https://hub.docker.com/u/pangeo, in case someone came along with a malicious PR), but perhaps another organization. That may be more work than it's worth though. Downstream users may want to be pinning the version they're using.

@scottyhq
Copy link
Member

The downside there is forgetting to sync staging & prod :) It'd be nice if we could upload the built image from CI somewhere (not https://hub.docker.com/u/pangeo, in case someone came along with a malicious PR), but perhaps another organization.

true, maybe rather than a separate branch we just go ahead and upload/overwrite the latest PR build to (pangeo/staging:latest) or (pangeo/staging:[branch-name]) with no intention of syncing. we could then just point a binder link to this dockerhub tag for testing. I guess the security concern is there, but we could just say in the github readme or dockerhub that these staging images are for testing only and shouldn't be used elsewhere?

@scottyhq
Copy link
Member

@TomAugspurger per ian's comment here: #50 (comment)

If you change your config to match https://github.com/scottyhq/pangeo-binder-test/tree/jlab1 we should go ahead and merge this I think

@TomAugspurger
Copy link
Member Author

Agreed that using that branch makes sense for now. I'm keeping an eye on the changes to dask-kubernetes and distributed. I'll update when this is no longer necessary.

@scottyhq scottyhq changed the title Change to jupyter-server-proxy Enable JupterLab=1: change to jupyter-server-proxy, noasync dask labextension branch Jul 30, 2019
@scottyhq scottyhq changed the title Enable JupterLab=1: change to jupyter-server-proxy, noasync dask labextension branch Enable JupterLab=1: noasync dask labextension branch Jul 30, 2019
base-notebook/binder/environment.yml Show resolved Hide resolved
base-notebook/binder/postBuild Outdated Show resolved Hide resolved
@TomAugspurger
Copy link
Member Author

Thanks. All green now.

@scottyhq scottyhq merged commit dee79d9 into pangeo-data:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade images to jupyterlab 1.0
2 participants