Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python, jlab, and tornado versions. #57

Merged
merged 5 commits into from
Jul 17, 2019

Conversation

TomAugspurger
Copy link
Member

  • python 3.6 -> 3.7
  • jupyterlab -> 1.0.0
  • tornado 5.1.1 -> 6.0.3

@TomAugspurger
Copy link
Member Author

Are we OK with the 3.6 -> 3.7 change? Or should I just focus on jupyterlab for now?

@scottyhq
Copy link
Member

scottyhq commented Jul 3, 2019

This is great, thanks @TomAugspurger! Are the Tornado>6 issues fixed? Seemed like there were lots of issues with JupyterHub and dask previously. We tried bumping to Python 3.7 a while back and there was some issue building the images... Maybe with repo2docker, but I think it should be fine now.

@TomAugspurger
Copy link
Member Author

Distributed fixed the tornado 6 issues in dask/distributed#2570. Notebook fixed them in jupyter/notebook#4439. So we should be OK, but who knows :)

I'm not sure when to deploy updates to binder.pangeo.io and prod.pangeo.io. I'll be offline tomorrow and most of Friday for the holiday.

@scottyhq
Copy link
Member

going to go ahead and merge this to experiment w/ jupyterlab 1.0. i'll just note that things currently seem to work well with Docker image 2019.07.01 if things break.

@scottyhq scottyhq merged commit 72588b5 into pangeo-data:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants