Repo2docker dask fixes #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamman
reviewed
May 22, 2019
| @@ -11,7 +11,7 @@ dependencies: | |||
| - dask-kubernetes>=0.8.0 | |||
| - nbserverproxy | |||
| - ipywidgets | |||
| - graphviz | |||
There was a problem hiding this comment.
Happy to try this again but I have a seem to remember this not working in a recent test. We'll see.
onbuild/r2d_overlay.py
Outdated
| @@ -46,10 +47,10 @@ def apply_environment(): | |||
| def apply_requirements(): | |||
| req_path = binder_path('requirements.txt') | |||
| env_path = binder_path('environment.yml') | |||
|
|
|||
| NB_PYTHON_PREFIX=os.environ['NB_PYTHON_PREFIX'] | |||
There was a problem hiding this comment.
nit: (here and above), can you add a space around the =?
There was a problem hiding this comment.
ok. added tests, including checking currently pinned versions - could be more sophisticated, but i think is good for now
|
@scottyhq - you may want to check out this: jupyterhub/repo2docker#690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully fixes #47 and #48