Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duckdb #578

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Add duckdb #578

merged 6 commits into from
Sep 11, 2024

Conversation

dcherian
Copy link
Contributor

No description provided.

@pangeo-bot
Copy link
Collaborator

/condalock
Automatically locking new conda environment, building, and testing images...

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Try on Mybinder.org!

@rabernat
Copy link
Member

Can you do xvec too while we are here?

@dcherian
Copy link
Contributor Author

it's already there

pangeo-docker-images/pangeo-notebook/environment.yml

Line 130 in 4552cca

- xvec

@weiji14
Copy link
Member

weiji14 commented Sep 11, 2024

/condalock

weiji14
weiji14 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. @scottyhq, do you want to check the docker image size difference?

weiji14
weiji14 reviewed Sep 11, 2024
View reviewed changes
pangeo-notebook/conda-lock.yml Outdated
Comment on lines 42005 to 42006
- name: xarray
version: 2024.7.0
version: 2024.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, reminder that we haven't fixed the xarray downgrade issue mentioned at #577 (comment)

@scottyhq
Copy link
Member

/condalock

@scottyhq
Copy link
Member

Looks ok to me. @scottyhq, do you want to check the docker image size difference?

CI log show an increase of ~170MB uncompressed:

localhost:5000/pangeo/pangeo-notebook   PR                09fc51b56bcf   21 minutes ago   4.96GB  (from 4.79GB)

Compressed images sizes on dockerhub are currently:

85bbcf926278   linux/amd64   1.64 GB
1f6cc912bd9e   linux/arm64   1.56 GB

Interestingly on my ARM mac I see a much larger disk usage:
pangeo/pangeo-notebook master 419058b9dc6f 3 hours ago 6.72GB

...So maybe there are some ways to make the ARM images smaller. But we should definitely dig into that separately. Seems like a good addition to me!

@scottyhq scottyhq merged commit a3e4d4c into pangeo-data:master Sep 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dcherian @pangeo-bot @rabernat @weiji14 @scottyhq