Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dask/daskhub helm chart #697

Merged
merged 9 commits into from
Aug 31, 2020
Merged

Use dask/daskhub helm chart #697

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0c7ae4c
Use dask/daskhub helm chart
TomAugspurger Aug 26, 2020
64d12f1
fixup
TomAugspurger Aug 26, 2020
980c0b7
override for now
TomAugspurger Aug 26, 2020
cfd052c
Merge remote-tracking branch 'upstream/staging' into daskhub
TomAugspurger Aug 27, 2020
5b39e81
remove DASK_GATEWAY__ADDRESS
TomAugspurger Aug 27, 2020
3d92420
fixup
TomAugspurger Aug 27, 2020
5ea9b9d
icesat, ooi
TomAugspurger Aug 27, 2020
ed5da36
Merge remote-tracking branch 'upstream/staging' into daskhub
TomAugspurger Aug 28, 2020
fdf93b7
disable ooi
TomAugspurger Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions deployments/icesat2/config/prod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,29 @@ daskhub:
hub:
extraEnv:
OAUTH_CALLBACK_URL: "https://aws-uswest2.pangeo.io/hub/oauth_callback"
singleuser:
profileList:
- display_name: "Latest Pangeo-notebook"
description: "https://github.com/pangeo-data/pangeo-docker-images/releases"
kubespawner_override:
image: pangeo/pangeo-notebook:latest
- display_name: "Latest Base-notebook"
description: "https://github.com/pangeo-data/pangeo-docker-images/releases"
kubespawner_override:
image: pangeo/base-notebook:latest
- display_name: "Latest ML-notebook"
description: "https://github.com/pangeo-data/pangeo-docker-images/releases"
kubespawner_override:
image: pangeo/ml-notebook:latest
mem_limit: 60G
mem_guarantee: 25G
environment: {'NVIDIA_DRIVER_CAPABILITIES': 'compute,utility'}
tolerations: [{'key': 'nvidia.com/gpu','operator': 'Equal','value': 'present','effect': 'NoSchedule'}]
extra_resource_limits: {"nvidia.com/gpu": "1"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think applying this resource request will make the toleration automatically be applied by some controller in k8s, but it wont hurt also manually applying the toleration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are from a merge conflict, but @scottyhq might want to take a look at the comment :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I understand correctly specifying extra_resource_limits: {"nvidia.com/gpu": "1"} automatically sets tolerations: [{'key': 'nvidia.com/gpu','operator': 'Equal','value': 'present','effect': 'NoSchedule'}] ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly these settings we're copied over from GCP and we never did two much experimentation to see what was necessary or not. Also things may have changed with more recent AMI versions and CUDA setups. This issue has some additional details jupyterhub/zero-to-jupyterhub-k8s#994 (comment)

- display_name: "ICESat-2 Hackweek 2020"
description: "https://github.com/ICESAT-2HackWeek/jupyter-image-2020"
kubespawner_override:
image: uwhackweeks/icesat2:latest
proxy:
https:
hosts:
Expand Down
27 changes: 27 additions & 0 deletions deployments/icesat2/config/staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,33 @@ pangeo:
memory: 1G
extraEnv:
OAUTH_CALLBACK_URL: "https://staging.aws-uswest2.pangeo.io/hub/oauth_callback"
singleuser:
profileList:
- display_name: "Staging Pangeo-notebook"
description: "https://github.com/pangeo-data/pangeo-docker-images/tree/master/pangeo-notebook"
kubespawner_override:
image: pangeo/pangeo-notebook:master
- display_name: "Latest Pangeo-notebook"
description: "https://github.com/pangeo-data/pangeo-docker-images/releases"
kubespawner_override:
image: pangeo/pangeo-notebook:latest
- display_name: "Staging Base-notebook"
description: "https://github.com/pangeo-data/pangeo-docker-images/tree/master/base-notebook"
kubespawner_override:
image: pangeo/base-notebook:master
- display_name: "Staging ML-notebook"
description: "https://github.com/pangeo-data/pangeo-docker-images/tree/master/ml-notebook"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think title or description should indicate you get a GPU machine, as that influence how the user may want to manually shut down the pod or so to save some money.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. Maybe "ML Notebook with GPU, please only use if you need it ;)"

kubespawner_override:
image: pangeo/ml-notebook:master
mem_limit: 60G
mem_guarantee: 25G
environment: {'NVIDIA_DRIVER_CAPABILITIES': 'compute,utility'}
tolerations: [{'key': 'nvidia.com/gpu','operator': 'Equal','value': 'present','effect': 'NoSchedule'}]
extra_resource_limits: {"nvidia.com/gpu": "1"}
- display_name: "ICESat-2 Hackweek 2020"
description: "https://github.com/ICESAT-2HackWeek/jupyter-image-2020"
kubespawner_override:
image: uwhackweeks/icesat2:latest
proxy:
https:
hosts:
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.