BUG: Bug fix for implicit upcast to float64 for large series (more than 1000000 rows) #62077
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Requirements
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.Issue Description
Performing binary operations on larger
Serieswithdtype == 'float32'leads to unexpected upcasts to float64.Above example prints
float32 float64.Using
to_numpy()on the series before addition inhibits the implicit upcast.Expected Behavior
I expect above snippet to print
float32 float32.Bug Fix
Changed scalar conversion logic for NumPy floating scalars to avoid automatic conversion to Python
float. Now returns a scalar of the original NumPy dtype to preserve type and prevent unintended dtype upcasts.