Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix wrong syntax in CI env yml files (mamba 2.0 compat) #59910

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Sep 27, 2024

All CI is failing with the new mamba 2.0 release. But it seems this is because we had invalid syntax (pip extras syntax) in our environment files, where mamba now fails on (previously used conda for parsing the yml files).

@mroeschke
Copy link
Member

It seems like there a few issues with mamba 2.0 with windows (mamba-org/setup-micromamba#227) and the list command (mamba-org/setup-micromamba#225) that we're also seeing here.

We may just need to pin the mamba version

@rhshadrach
Copy link
Member

I opened #59912 - planning to merge as soon as that's green. We can then use this to unpin once upstream is fixed.

Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 29, 2024
@jorisvandenbossche jorisvandenbossche added the CI Continuous Integration label Oct 30, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Oct 31, 2024
@mroeschke mroeschke merged commit de4eaf8 into pandas-dev:main Oct 31, 2024
50 of 51 checks passed
@mroeschke
Copy link
Member

Thanks @jorisvandenbossche

Copy link

lumberbot-app bot commented Oct 31, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 de4eaf8b2e7c6b840dbd0198d8c3edf5eaf5afff
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #59910: CI: fix wrong syntax in CI env yml files (mamba 2.0 compat)'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-59910-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #59910 on branch 2.3.x (CI: fix wrong syntax in CI env yml files (mamba 2.0 compat))"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche jorisvandenbossche deleted the fix-ci branch November 4, 2024 06:17
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Nov 4, 2024
…ev#59910)

* fix wrong syntax in CI env yml files

* fix other files

* remove micromamba pin

(cherry picked from commit de4eaf8)
@jorisvandenbossche
Copy link
Member Author

Manual backport -> #60175

jorisvandenbossche added a commit that referenced this pull request Nov 4, 2024
…compat) (#59910) (#60175)

CI: fix wrong syntax in CI env yml files (mamba 2.0 compat) (#59910)

* fix wrong syntax in CI env yml files

* fix other files

* remove micromamba pin

(cherry picked from commit de4eaf8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants