Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/TST: Check for tzset in set_timezone #59893

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

mroeschke
Copy link
Member

Appears the ARM tests are failing because tzset is not available. This API is limited to certain platform so we should be checking if we can set a tz in the first place

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite CI Continuous Integration Timezones Timezone data dtype ARM aarch64 architecture labels Sep 25, 2024
@mroeschke mroeschke added this to the 2.3 milestone Sep 25, 2024
@mroeschke
Copy link
Member Author

Looks like the arm job is passing now so merging

@mroeschke mroeschke merged commit b948821 into pandas-dev:main Sep 26, 2024
51 checks passed
@mroeschke mroeschke deleted the tst/arm/tzset branch September 26, 2024 00:47
@jorisvandenbossche
Copy link
Member

@meeseeksdev backport to 2.3.x

Copy link

lumberbot-app bot commented Oct 2, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 b9488218ae27b70d1669a932ab16e8ce5a257cf0
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #59893: CI/TST: Check for tzset in set_timezone'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-59893-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #59893 on branch 2.3.x (CI/TST: Check for tzset in set_timezone)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

jorisvandenbossche pushed a commit to jorisvandenbossche/pandas that referenced this pull request Oct 2, 2024
* CI/TST: Check for tzset in set_timezone

* adjust test message

(cherry picked from commit b948821)
@jorisvandenbossche
Copy link
Member

Manual backport in #59941

jorisvandenbossche added a commit that referenced this pull request Oct 3, 2024
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM aarch64 architecture CI Continuous Integration Testing pandas testing functions or related to the test suite Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants