Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Refactor _create_delegator_method using functools #59878

Merged
merged 26 commits into from
Oct 8, 2024
Merged

DOC: Refactor _create_delegator_method using functools #59878

merged 26 commits into from
Oct 8, 2024

Conversation

saldanhad
Copy link
Contributor

@saldanhad saldanhad commented Sep 23, 2024 •
edited
Loading 

        -i "pandas.Series.cat.add_categories PR01,PR02" \
        -i "pandas.Series.cat.as_ordered PR01" \
        -i "pandas.Series.cat.as_unordered PR01" \
        -i "pandas.Series.cat.remove_categories PR01,PR02" \
        -i "pandas.Series.cat.remove_unused_categories PR01" \
        -i "pandas.Series.cat.rename_categories PR01,PR02" \
        -i "pandas.Series.cat.reorder_categories PR01,PR02" \
        -i "pandas.Series.cat.set_categories PR01,PR02" \

        -i "pandas.Series.dt.to_period PR01,PR02" \
        -i "pandas.Series.dt.as_unit PR01,PR02" \
        -i "pandas.Series.dt.ceil PR01,PR02" \
        -i "pandas.Series.dt.day_name PR01,PR02" \
        -i "pandas.Series.dt.floor PR01,PR02" \
        -i "pandas.Series.dt.month_name PR01,PR02" \
        -i "pandas.Series.dt.normalize PR01" \
        -i "pandas.Series.dt.round PR01,PR02" \
        -i "pandas.Series.dt.strftime PR01,PR02" \
        -i "pandas.Series.dt.total_seconds PR01" \
        -i "pandas.Series.dt.tz_convert PR01,PR02" \
        -i "pandas.Series.dt.tz_localize PR01,PR02" \

@saldanhad saldanhad changed the title DOC: Add tag required tag to series.rst DOC: Add required tag to series.rst Sep 23, 2024
@saldanhad saldanhad changed the title DOC: Add required tag to series.rst DOC: Add doc for Series.dt.to_timestamp to datetimes.py Sep 23, 2024
@saldanhad saldanhad changed the title DOC: Add doc for Series.dt.to_timestamp to datetimes.py DOC: Add doc for series.dt.to_timestamp & refactor _create_delegator_method Sep 24, 2024
yuanx749
yuanx749 reviewed Sep 25, 2024
View reviewed changes
pandas/core/accessor.py Outdated Show resolved Hide resolved
@saldanhad saldanhad marked this pull request as draft September 28, 2024 14:23
@saldanhad saldanhad marked this pull request as ready for review October 1, 2024 15:51
@saldanhad
Copy link
Contributor Author

ping @rhshadrach , @mroeschke for review.

@rhshadrach
Copy link
Member

/preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/59878/

rhshadrach
rhshadrach requested changes Oct 5, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

doc/source/whatsnew/v3.0.0.rst Outdated Show resolved Hide resolved
pandas/core/accessor.py Outdated Show resolved Hide resolved
pandas/core/arrays/categorical.py Outdated Show resolved Hide resolved
pandas/core/arrays/categorical.py Outdated Show resolved Hide resolved
pandas/core/arrays/datetimes.py Outdated Show resolved Hide resolved
@rhshadrach rhshadrach mentioned this pull request Oct 5, 2024
Open
@saldanhad saldanhad changed the title DOC: Add doc for series.dt.to_timestamp & refactor _create_delegator_method DOC: Refactor _create_delegator_method using functools Oct 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/59878/

rhshadrach
rhshadrach approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added Docs Accessors accessor registration mechanism (not .str, .dt, .cat) labels Oct 6, 2024
mroeschke
mroeschke reviewed Oct 6, 2024
View reviewed changes
pandas/core/accessor.py Outdated Show resolved Hide resolved
@saldanhad
Copy link
Contributor Author

Just inquiring to see if i've missed to implement any changes here ? @mroeschke

@mroeschke mroeschke added this to the 3.0 milestone Oct 8, 2024
@mroeschke mroeschke merged commit f94860e into pandas-dev:main Oct 8, 2024
51 checks passed
@mroeschke
Copy link
Member

Thanks @saldanhad

@saldanhad saldanhad deleted the to_timestamp branch October 8, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanx749 yuanx749 yuanx749 left review comments

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Accessors accessor registration mechanism (not .str, .dt, .cat) Docs
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

DOC: Questions on Usage of *args, **kwargs, and inplace parameters in pandas.Series.cat methods
4 participants
@saldanhad @rhshadrach @mroeschke @yuanx749