String dtype: allow string dtype for non-raw apply with numba engine #59854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Strings
lithomas1
approved these changes
Sep 24, 2024
mroeschke
approved these changes
Sep 25, 2024
|
Thanks @jorisvandenbossche |
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Oct 10, 2024
…andas-dev#59854) * String dtype: allow string dtype for non-raw apply with numba engine * remove xfails * clean-up
jorisvandenbossche
added a commit
that referenced
this pull request
Oct 10, 2024
…59854) * String dtype: allow string dtype for non-raw apply with numba engine * remove xfails * clean-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#55104 enabled using numba with
raw=Falseinapply()(BTW, this seems rather undocumented?), but that PR had some specific hack for object dtype index. Extending that hack to also convert str dtype index to numpy strings under the hood (this might hurt performance, but for now just want to get this working)xref #54792