Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Separate out examples - pandas.str.is methods #59850

Merged
merged 8 commits into from
Sep 29, 2024
Merged

DOC: Separate out examples - pandas.str.is methods #59850

merged 8 commits into from
Sep 29, 2024

Conversation

saldanhad
Copy link
Contributor

@saldanhad saldanhad changed the title Seperate out examples for pandas.str.is methods in docs Separate out examples - pandas.str.is methods Sep 20, 2024
@saldanhad saldanhad changed the title Separate out examples - pandas.str.is methods DOC: Separate out examples - pandas.str.is methods Sep 26, 2024
@saldanhad saldanhad marked this pull request as draft September 26, 2024 06:21
@saldanhad saldanhad marked this pull request as ready for review September 26, 2024 09:56
@saldanhad
Copy link
Contributor Author

Hi @rhshadrach, I have refactored the docstrings to separate the Examples and See Also sections for each ismethod, no code changes were made and tested the changes locally. However, I noticed that the unit tests are now failing, which seems to be related to an issue with the CI script. Could you kindly review the changes and provide your feedback when possible? Thank you.

@saldanhad saldanhad marked this pull request as draft September 28, 2024 12:51
@saldanhad saldanhad marked this pull request as ready for review September 28, 2024 14:23
@rhshadrach
Copy link
Member

/preview

@github-actions GitHub Actions
Copy link
Contributor

Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/59850/

rhshadrach
rhshadrach requested changes Sep 29, 2024
View reviewed changes
pandas/core/strings/accessor.py Outdated Show resolved Hide resolved
rhshadrach
rhshadrach approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added Docs Strings String extension data type and string data labels Sep 29, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Sep 29, 2024
@rhshadrach rhshadrach merged commit 90c26ce into pandas-dev:main Sep 29, 2024
57 checks passed
@rhshadrach
Copy link
Member

Thanks @saldanhad!

@saldanhad saldanhad deleted the dev1 branch September 29, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Docs Strings String extension data type and string data
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

DOC: Separate Examples for String Methods (str.isalnum(), str.isalpha(), etc.) in docs
2 participants
@saldanhad @rhshadrach