Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc #59793

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Fix doc #59793

merged 7 commits into from
Sep 30, 2024

Conversation

fbourgey
Copy link
Contributor

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

doc/source/user_guide/dsintro.rst Outdated Show resolved Hide resolved
@rhshadrach rhshadrach added Docs Series Series data structure Constructors Series/DataFrame/Index/pd.array Constructors labels Sep 14, 2024
Comment on lines 91 to 92
the length of **index**. If the index is not provided, it defaults
to ``RangeIndex (0, 1, 2, …, n)``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n here is not defined, and I think in this notation would be 0, but this is not the notation used to construct a RangeIndex. In particular, RangeIndex(0) here is wrong. Can you make this RangeIndex(1).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the change.

@rhshadrach
Copy link
Member

/preview

Copy link
Contributor

Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/59793/

provided. The value will be repeated to match the length of **index**.
If ``data`` is a scalar value, the value will be repeated to match
the length of **index**. If the **index** is not provided, it defaults
to ``RangeIndex (1)``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the space so it is RangeIndex(1).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 3.0 milestone Sep 30, 2024
@rhshadrach rhshadrach merged commit e78ebd3 into pandas-dev:main Sep 30, 2024
20 checks passed
@rhshadrach
Copy link
Member

Thanks @fbourgey!

@fbourgey fbourgey deleted the fix-doc-data-structures branch October 8, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Docs Series Series data structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Intro to data structures
2 participants