Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted backports for 2.2.x #59785

Merged

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 added Build Library building on various platforms Python 3.13 labels Sep 12, 2024
@lithomas1 lithomas1 added the CI Continuous Integration label Sep 12, 2024
@lithomas1 lithomas1 changed the title Backport PR #59065: ENH: Fix Python 3.13 test failures & enable CI Assorted backports Sep 12, 2024
@lithomas1 lithomas1 added this to the 2.2.3 milestone Sep 12, 2024
* Remove deprecated plot_date calls

These were deprecated in Matplotlib 3.9.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit c9bc480)
@jorisvandenbossche jorisvandenbossche changed the title Assorted backports Assorted backports for 2.2.x Sep 12, 2024
@lithomas1 lithomas1 force-pushed the auto-backport-of-pr-59065-on-2.2.x branch from 91225ea to 1660c51 Compare September 13, 2024 19:18
@@ -257,7 +257,7 @@ jobs:
. ~/virtualenvs/pandas-dev/bin/activate
python -m pip install --no-cache-dir -U pip wheel setuptools meson[ninja]==1.2.1 meson-python==0.13.1
python -m pip install numpy --config-settings=setup-args="-Dallow-noblas=true"
python -m pip install --no-cache-dir versioneer[toml] cython python-dateutil pytz pytest>=7.3.2 pytest-xdist>=2.2.0 hypothesis>=6.46.1
python -m pip install --no-cache-dir versioneer[toml] cython python-dateutil pytz<2024.2 pytest>=7.3.2 pytest-xdist>=2.2.0 hypothesis>=6.46.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytz 2024.2 is causing a failure in test_array.py
(relating to constructing an array from datetime objects with pytz timezones)

I've pinned in testing for now.

I'm wondering if I should pin it as a dep too?
(as far as I can tell, all pytz did was update their IANA tzdb to 2024.2, so maybe this fixes itself when everyone else does too?)

@WillAyd
Copy link
Member

WillAyd commented Sep 13, 2024

On phone so sorry for not linking better, but I think the DTI failures need to be partially pulled from #55901.

If you look at the commits in the 2.3 branch I started you will see a commit where I do that

@lithomas1 lithomas1 force-pushed the auto-backport-of-pr-59065-on-2.2.x branch from 1660c51 to 679e45e Compare September 14, 2024 12:21
@lithomas1
Copy link
Member Author

On phone so sorry for not linking better, but I think the DTI failures need to be partially pulled from #55901.

If you look at the commits in the 2.3 branch I started you will see a commit where I do that

I think I have most of the relevant fixes picked from your PR, actually.
(and some of the rest I will fix by backporting some other PRs).

Only headscratcher for me right now is the ARM build jobs (which also happen to fail on main).
Interesting that it's only the build and not the test job, though ....

@lithomas1
Copy link
Member Author

all green 🚀

@lithomas1 lithomas1 merged commit f7b6378 into pandas-dev:2.2.x Sep 18, 2024
99 checks passed
@lithomas1 lithomas1 deleted the auto-backport-of-pr-59065-on-2.2.x branch September 18, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration Python 3.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants