REF (string): move ArrowStringArrayNumpySemantics methods to base class #59501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 14, 2024
pandas/core/arrays/arrow/array.py
Outdated
| @@ -734,7 +734,14 @@ def _cmp_method(self, other, op) -> ArrowExtensionArray: | |||
| raise NotImplementedError( | |||
| f"{op.__name__} not implemented for {type(other)}" | |||
| ) | |||
| return ArrowExtensionArray(result) | |||
| result = ArrowExtensionArray(result) | |||
| if self.dtype.na_value is np.nan: # type: ignore[comparison-overlap] | |||
There was a problem hiding this comment.
Semantically wouldn't this be better defined in ArrowStringArray? Since self.dtype must not be a ArrowDtype here
There was a problem hiding this comment.
either way works; i preferred this since it was maximally high in the inheritance chain
There was a problem hiding this comment.
Yeah I would prefer this in ArrowStringArray since this logic is specific to that subclass.
mroeschke
added
Refactor
mroeschke
approved these changes
Aug 15, 2024
|
Thanks @jbrockmendel |
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…ss (pandas-dev#59501) * REF: move ArrowStringArrayNumpySemantics methods to parent class * REF: move methods to ArrowStringArray * mypy fixup * Fix incorrect double-unpacking * move methods to subclass
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…ss (pandas-dev#59501) * REF: move ArrowStringArrayNumpySemantics methods to parent class * REF: move methods to ArrowStringArray * mypy fixup * Fix incorrect double-unpacking * move methods to subclass
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…ss (pandas-dev#59501) * REF: move ArrowStringArrayNumpySemantics methods to parent class * REF: move methods to ArrowStringArray * mypy fixup * Fix incorrect double-unpacking * move methods to subclass
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…ss (pandas-dev#59501) * REF: move ArrowStringArrayNumpySemantics methods to parent class * REF: move methods to ArrowStringArray * mypy fixup * Fix incorrect double-unpacking * move methods to subclass
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 27, 2024
…ss (pandas-dev#59501) * REF: move ArrowStringArrayNumpySemantics methods to parent class * REF: move methods to ArrowStringArray * mypy fixup * Fix incorrect double-unpacking * move methods to subclass
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Sep 20, 2024
…ss (pandas-dev#59501) * REF: move ArrowStringArrayNumpySemantics methods to parent class * REF: move methods to ArrowStringArray * mypy fixup * Fix incorrect double-unpacking * move methods to subclass
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
…ss (pandas-dev#59501) * REF: move ArrowStringArrayNumpySemantics methods to parent class * REF: move methods to ArrowStringArray * mypy fixup * Fix incorrect double-unpacking * move methods to subclass
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
…ss (pandas-dev#59501) * REF: move ArrowStringArrayNumpySemantics methods to parent class * REF: move methods to ArrowStringArray * mypy fixup * Fix incorrect double-unpacking * move methods to subclass
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 3, 2024
…ss (pandas-dev#59501) * REF: move ArrowStringArrayNumpySemantics methods to parent class * REF: move methods to ArrowStringArray * mypy fixup * Fix incorrect double-unpacking * move methods to subclass
jorisvandenbossche
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Oct 7, 2024
…ss (pandas-dev#59501) * REF: move ArrowStringArrayNumpySemantics methods to parent class * REF: move methods to ArrowStringArray * mypy fixup * Fix incorrect double-unpacking * move methods to subclass
jorisvandenbossche
pushed a commit
that referenced
this pull request
Oct 9, 2024
…ss (#59501) * REF: move ArrowStringArrayNumpySemantics methods to parent class * REF: move methods to ArrowStringArray * mypy fixup * Fix incorrect double-unpacking * move methods to subclass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.