Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: More doc fix for dtype_backend #59071

Merged
merged 20 commits into from
Aug 11, 2024
Merged

DOC: More doc fix for dtype_backend #59071

merged 20 commits into from
Aug 11, 2024

Conversation

luke396
Copy link
Contributor

@luke396 luke396 commented Jun 22, 2024 •
edited by rhshadrach
Loading

@luke396 luke396 marked this pull request as ready for review June 22, 2024 13:49
@luke396 luke396 requested a review from rhshadrach as a code owner June 22, 2024 13:49
@droussea2001 droussea2001 mentioned this pull request Jun 22, 2024
Open
4 tasks
@luke396 luke396 requested a review from rhshadrach June 23, 2024 01:40
rhshadrach
rhshadrach requested changes Jul 3, 2024
View reviewed changes
pandas/core/dtypes/cast.py Outdated Show resolved Hide resolved
pandas/core/generic.py Outdated Show resolved Hide resolved
pandas/io/clipboards.py Outdated Show resolved Hide resolved
rhshadrach
rhshadrach requested changes Jul 20, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me when we have numpy_nullable or pyarrow lines in the docs, they should closely mirror each other. See requests below.

pandas/core/dtypes/cast.py Outdated Show resolved Hide resolved
pandas/core/generic.py Outdated Show resolved Hide resolved
pandas/core/tools/numeric.py Show resolved Hide resolved
pandas/io/clipboards.py Outdated Show resolved Hide resolved
pandas/io/excel/_base.py Outdated Show resolved Hide resolved
pandas/io/sql.py Outdated Show resolved Hide resolved
pandas/io/sql.py Outdated Show resolved Hide resolved
pandas/io/sql.py Outdated Show resolved Hide resolved
pandas/io/sql.py Outdated Show resolved Hide resolved
pandas/io/xml.py Outdated Show resolved Hide resolved
@rhshadrach rhshadrach added Docs IO Data IO issues that don't fit into a more specific label labels Aug 4, 2024
@rhshadrach rhshadrach mentioned this pull request Aug 4, 2024
Closed
3 tasks
@luke396
Copy link
Contributor Author

luke396 commented Aug 9, 2024

Honestly, I've lost track of the current PR, but I'll do my utmost to address all comments. If further changes are needed, I'll make them promptly.

@luke396 luke396 requested a review from rhshadrach August 9, 2024 12:00
rhshadrach
rhshadrach requested changes Aug 10, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! One last line and I think we're good to go.

pandas/core/generic.py Show resolved Hide resolved
@luke396
fix build
53423be 
fix review
rhshadrach
rhshadrach approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 3.0 milestone Aug 11, 2024
@rhshadrach rhshadrach merged commit a3f2d48 into pandas-dev:main Aug 11, 2024
47 checks passed
@rhshadrach
Copy link
Member

Thanks @luke396!

@luke396 luke396 deleted the fix-dtype_backend-doc branch August 11, 2024 12:40
shreyas-dev pushed a commit to shreyas-dev/pandas that referenced this pull request Aug 13, 2024
@luke396 @shreyas-dev
DOC: More doc fix for dtype_backend (pandas-dev#59071)
998708e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Docs IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

BUG: pandas.read_parquet () dtype_backend argument does not get the default value as documented
2 participants
@luke396 @rhshadrach