Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fixing PR01 errors for pandas.Categorical and pandas.Categorical.__array__ #57561

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

jordan-d-murphy
Copy link
Contributor

All PR01 Errors resolved in the following cases:

  1. scripts/validate_docstrings.py --format=actions --errors=PR01 pandas.Categorical
  2. scripts/validate_docstrings.py --format=actions --errors=PR01 pandas.Categorical.array

jordan-d-murphy and others added 2 commits February 22, 2024 23:33
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@jordan-d-murphy
Copy link
Contributor Author

Thanks for the feedback - updated this with your suggestion, can you take another look @mroeschke?

@mroeschke mroeschke added this to the 3.0 milestone Feb 23, 2024
@mroeschke mroeschke merged commit 54d2033 into pandas-dev:main Feb 23, 2024
47 checks passed
@mroeschke
Copy link
Member

Thanks @jordan-d-murphy

@jordan-d-murphy jordan-d-murphy deleted the issue#57438_1 branch February 23, 2024 17:14
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
….__array__ (pandas-dev#57561)

* fixing PR01 errors for pandas.Categorical and pandas.Categorical.__array__

* updated dtype to np.dtype

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

---------

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants