Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #55761 on branch 2.1.x (BUG: DatetimeIndex.diff raising TypeError) #55819

Conversation

lukemanley
Copy link
Member

No description provided.

@lukemanley lukemanley added Bug Index Related to the Index class or subclasses labels Nov 4, 2023
@lukemanley lukemanley added this to the 2.1.3 milestone Nov 4, 2023
@lukemanley
Copy link
Member Author

@mroeschke - were you planning to backport anything from #55524? It looks like some of the failures here (in 2.1.x) could use some of the updates you made in that PR.

e.g test_parse_tz_aware is failing due to a units mismatch and it looks like you added an explicit cast to nanoseconds in that PR:

result.index = result.index.as_unit("ns")

@mroeschke
Copy link
Member

Ah I see. Definitely should not backport the dependency bumps, but potentially 2.1.x might not have pyarrow pinned like the main branch was and some of these code changes could be ported over there.

But the failures are not related to this change right?

@lukemanley
Copy link
Member Author

But the failures are not related to this change right?

Correct, the failures look unrelated

@mroeschke mroeschke merged commit 0bf70c7 into pandas-dev:2.1.x Nov 6, 2023
@lukemanley lukemanley deleted the 2.1.x-auto-backport-of-pr-55761-on-2.1.x branch November 16, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Index Related to the Index class or subclasses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants