CI: Exclude benchmarks directory when publishing docs #55380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 3, 2023
| @@ -67,7 +67,7 @@ jobs: | |||
| run: cp doc/cheatsheet/Pandas_Cheat_Sheet* web/build/ | |||
|
|
|||
| - name: Upload web | |||
| run: rsync -az --delete --exclude='pandas-docs' --exclude='docs' web/build/ web@${{ secrets.server_ip }}:/var/www/html | |||
| run: rsync -az --delete --exclude='pandas-docs' --exclude='docs' --exclude='benchmarks' web/build/ web@${{ secrets.server_ip }}:/var/www/html | |||
There was a problem hiding this comment.
Is benchmarks going to be created or did you mean asv_bench?
There was a problem hiding this comment.
This is not on the pandas repo. It's in the rendered website directory. So, next to index.html, about/team.html... The benchmarks server will be creating and pushing a benchmarks directory with the html files that asv renders with the results.
@DeaMariaLeon and myself will be explaining and documenting all the new benchmark stuff we're building. We'll also be asking what improvements people would like to see in the benchmarks infrastructure once we replicate more or less what we had until now but with our OVH server and a bit simpler way to run things.
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're setting up the new benchmarks server to publish the asv results website to https://pandas.pydata.org/benchmarks.
We need the exclude in this PR so updating the website doesn't delete the benchmarks directory.