Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fixing EX01 - Added examples #54278

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Conversation

DeaMariaLeon
Copy link
Member

Towards #37875

Example by itself because it was not raising the warning every time locally.

@DeaMariaLeon DeaMariaLeon added this to the 2.1 milestone Jul 27, 2023
Copy link

@adityaraute adityaraute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroeschke
Copy link
Member

Error: /home/runner/work/pandas/pandas/pandas/errors/__init__.py:46:GL03:pandas.errors.PerformanceWarning:Double line break found; please use only one blank line to separate sections or paragraphs, and do not leave blank lines at the end of docstrings
Error: /home/runner/work/pandas/pandas/pandas/errors/__init__.py:46:EX02:pandas.errors.PerformanceWarning:Examples do not pass tests:
**********************************************************************
Line 18, in pandas.errors.PerformanceWarning
Failed example:
    df.loc[(1, 'z')]
Expected:
    Traceback (most recent call last):
    PerformanceWarning: indexing past lexsort depth may impact performance.
    df.loc[(1, 'z')])
              jolie
    jim  joe
    1    z        3
Got:
             jolie
    jim joe       
    1   z        3

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgbm, thanks @DeaMariaLeon !

@MarcoGorelli MarcoGorelli merged commit 3fb33d6 into pandas-dev:main Jul 28, 2023
31 of 33 checks passed
@DeaMariaLeon DeaMariaLeon deleted the Jul27-2 branch July 28, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants