Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrote test for Issue#29576 with resampling in non-unitary quarters #54269

Closed
wants to merge 1 commit into from

Conversation

joshdelg
Copy link

@joshdelg joshdelg commented Jul 26, 2023

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are failing, and Mambaforge-Darwin-x86_64.sh was accidentally committed

@joshdelg
Copy link
Author

joshdelg commented Aug 9, 2023

Noticed the tests failed, I don't think the issue was fixed. Is the the expected output given in the issue description what the test should anticipate?

@mroeschke
Copy link
Member

I don't think expected is correctly constructed to match #29576 (comment)

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

startingMonth ignored on non-unitary Quarter periods
2 participants