Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC towards complying with EX01 specs #51055

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

DeaMariaLeon
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Towards #37875

Added functions to ignore on code_checks.sh, they are failing EX02 tests.
More functions were failing EX02, but added line to format.py to eliminate display errors.

@MarcoGorelli

@MarcoGorelli MarcoGorelli added Code Style Code style, linting, code_checks Docs labels Jan 29, 2023
@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Jan 29, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DeaMariaLeon !

Looks like there's one more:

Line 80, in pandas.Series.copy
Failed example:
    s
Expected:
    a    3
    b    4
    dtype: int64
Got:
    a    3
    b    2
    dtype: int64
**********************************************************************
Line 84, in pandas.Series.copy
Failed example:
    shallow
Expected:
    a    3
    b    4
    dtype: int64
Got:
    a    1
    b    4
    dtype: int64

It's really good that you're doing this, you're helping unearth actual issues!

@DeaMariaLeon
Copy link
Member Author

I wonder why that function is not showing up in the errors locally.

Anyhow, best motivational phrase ever:

It's really good that you're doing this, you're helping unearth actual issues!

Thanks @MarcoGorelli. :)

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks @DeaMariaLeon , will merge on green

Don't know why that particular function passed locally but not in CI

@MarcoGorelli MarcoGorelli merged commit d6afc86 into pandas-dev:main Jan 30, 2023
@DeaMariaLeon DeaMariaLeon deleted the fixing-EX01 branch January 30, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants