Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

48855 style fix pylint issues pointless string statement #49880

Merged
merged 6 commits into from
Nov 29, 2022
Merged

48855 style fix pylint issues pointless string statement #49880

merged 6 commits into from
Nov 29, 2022

Conversation

seanjedi
Copy link
Contributor

@seanjedi seanjedi commented Nov 24, 2022 •
edited
Loading

@seanjedi
feat: Adding pylint check pointless-string-statement
d76439c 
Fixing issues for pointless-string-statement so that we can add the PyLint check to the project
@seanjedi
Merge branch 'pandas-dev:main' into seanjedi-48855_STYLE_fix_pylint_i…
75c4771 
…ssues_pointless_string_statement
@seanjedi seanjedi mentioned this pull request Nov 24, 2022
Closed
MarcoGorelli
MarcoGorelli reviewed Nov 24, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this

pandas/tests/io/parser/common/test_read_errors.py Outdated Show resolved Hide resolved
MarcoGorelli
MarcoGorelli requested changes Nov 28, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating! just got a few more comments

pandas/tests/frame/methods/test_reset_index.py Outdated Show resolved Hide resolved
pandas/tests/indexes/multi/test_analytics.py Outdated Show resolved Hide resolved
pandas/tests/indexing/interval/test_interval_new.py Outdated Show resolved Hide resolved
pandas/tests/io/parser/common/test_read_errors.py Outdated Show resolved Hide resolved
@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Nov 28, 2022
MarcoGorelli
MarcoGorelli approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seanjedi !

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Nov 29, 2022
@MarcoGorelli MarcoGorelli merged commit a7ac7d6 into pandas-dev:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@seanjedi @MarcoGorelli @mroeschke