Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

48855 style fix pylint issues #49848

Closed
wants to merge 11 commits into from
Closed

48855 style fix pylint issues #49848

wants to merge 11 commits into from

Conversation

seanjedi
Copy link
Contributor

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@seanjedi seanjedi mentioned this pull request Nov 23, 2022
Closed
@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Nov 23, 2022
@MarcoGorelli
Copy link
Member

thanks @seanjedi - as mentioned here, this check seems to be all false-positive, so it'd be better to keep it turned off to not risk annoying contributors

closing then, but thanks anyway for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanjedi @MarcoGorelli @mroeschke