Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/CoW: use lazy copy in set_index method #49557

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

ntachukwu
Copy link
Contributor

Copy-on-Write in set_index

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking good, just added some minor comments on the test

pandas/tests/copy_view/test_methods.py Outdated Show resolved Hide resolved
pandas/tests/copy_view/test_methods.py Outdated Show resolved Hide resolved
@jorisvandenbossche jorisvandenbossche merged commit d3e84c5 into pandas-dev:main Nov 15, 2022
@jorisvandenbossche
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants