Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: enforce Series.__setitem__ behavior with Float64Index and non-present int key #49530

Merged
merged 2 commits into from
Nov 7, 2022
Merged

DEPR: enforce Series.__setitem__ behavior with Float64Index and non-present int key #49530

merged 2 commits into from
Nov 7, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

topper-123
topper-123 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@topper-123 topper-123 added Indexing Related to indexing on series/frames, not to indexes themselves Deprecate Functionality to remove in pandas labels Nov 7, 2022
@topper-123 topper-123 added this to the 2.0 milestone Nov 7, 2022
@mroeschke
Copy link
Member

Merge conflict otherwise LGTM

@mroeschke mroeschke merged commit ca99c94 into pandas-dev:main Nov 7, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-indexing-4 branch November 7, 2022 23:16
@jbrockmendel jbrockmendel mentioned this pull request Nov 7, 2022
Closed
phofl pushed a commit to phofl/pandas that referenced this pull request Nov 9, 2022
@jbrockmendel @phofl
DEPR: enforce Series.__setitem__ behavior with Float64Index and non-p…
aa63800 
…resent int key (pandas-dev#49530)
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@jbrockmendel @noatamir
DEPR: enforce Series.__setitem__ behavior with Float64Index and non-p…
1ebda64 
…resent int key (pandas-dev#49530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@topper-123 topper-123 topper-123 approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @topper-123