DEP: Enforce set_values and set_codes inplace and positional args deprecation #49084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
WillAyd
requested changes
Oct 19, 2022
| @@ -254,12 +251,10 @@ def test_is_(): | |||
| mi4 = mi3.view() | |||
|
|
|||
| # GH 17464 - Remove duplicate MultiIndex levels | |||
| with tm.assert_produces_warning(FutureWarning): | |||
| mi4.set_levels([list(range(10)), list(range(10))], inplace=True) | |||
| mi4 = mi4.set_levels([list(range(10)), list(range(10))]) | |||
There was a problem hiding this comment.
Similar comment - might be able to just remove
There was a problem hiding this comment.
This is a bit different, would like to keep it
mroeschke
reviewed
Oct 19, 2022
| @@ -145,7 +145,8 @@ Deprecations | |||
| Removal of prior version deprecations/changes | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| - Disallow passing non-round floats to :class:`Timestamp` with ``unit="M"`` or ``unit="Y"`` (:issue:`47266`) | |||
| - | |||
| - Remove argument ``inplace`` from :meth:`MultiIndex.set_levels` and :meth:`MultiIndex.set_codes` (:issue:`35626`) | |||
| - Disallow passing positional arguments to :meth:`MultiIndex.set_levels` and :meth:`MultiIndex.set_codes` (:issue:`41485`) | |||
There was a problem hiding this comment.
Could you add a test where set_levels and set_codes raises when passed positional args?
WillAyd
approved these changes
Oct 20, 2022
|
Thanks @phofl |
phofl
added a commit
to phofl/pandas
that referenced
this pull request
Oct 21, 2022
…recation (pandas-dev#49084) * DEP: Enforce set_values and set_codes inplace and positional args deprecation * Fix * Add whatsnew * Add test
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…recation (pandas-dev#49084) * DEP: Enforce set_values and set_codes inplace and positional args deprecation * Fix * Add whatsnew * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#41485 #35626