DOC: reverted directive for SAS logo white #48935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
datapythonista
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
lgtm, thanks @lorenzovngl
I think the original problem is that the :class: directive is for :image: directives in the pydata sphinx theme. But this is a :img-top: element from sphinx panels if I'm not wrong: https://sphinx-panels.readthedocs.io/en/latest/#card-layout
Not sure if classes can be specified for them, I see some elements of sphinx panels use :classes:, but since the error is that the directive is just rendered, I wonder is any subdirective will work at all.
I guess if no other solution seems reasonable, we can also make the SAS word gray.
But for now let's just revert to this, thanks for this PR.
datapythonista
changed the title
mroeschke
approved these changes
Oct 5, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 5, 2022
|
Thanks @lorenzovngl |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
WEB: reverted directive for SAS logo white
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requrest is related to #48790. These changes revert the directive, that don't work as expected and causes a code leak on the web page, to use a different image depending on the theme used:
I can't figured out how to solve it, so I restored a previous version of the file (see Commits tab) and I will open an issue about this problem.