-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Make deprecate_nonkeyword_arguments alter function signature #48693
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4b35e7c
Make deprecate_nonkeyword_arguments alter function signature
hauntsaninja d720f62
Merge remote-tracking branch 'upstream/main' into deprecate-sig
hauntsaninja 44014ed
reformat
hauntsaninja f642a04
type ignore
hauntsaninja f60bd70
add comment
hauntsaninja 8b3e68c
changelog entry
hauntsaninja d3d912b
clearer phrasing
hauntsaninja b39ae26
move changelog entry
hauntsaninja 5c4836a
add test for positional-only
hauntsaninja 75769a7
Update doc/source/whatsnew/v1.5.1.rst
hauntsaninja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test that requires
p.POSITIONAL_ONLY
? I tried deleting it from here, andpytest pandas/tests/util/test_deprecate_nonkeyword_arguments.py
still passedIf there's not a test that needs this, could we add a little one that does?
EDIT: apologies, I wrote this comment then forgot to add this comment to the previous review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a test!