Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: keep using ObjectEngine for ExtensionArrays for 1.5 #48472

Merged
merged 1 commit into from
Sep 9, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pandas/core/indexes/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -5155,6 +5155,9 @@ def _get_engine_target(self) -> ArrayLike:
if isinstance(vals, StringArray):
# GH#45652 much more performant than ExtensionEngine
return vals._ndarray
if type(self) is Index and isinstance(self._values, ExtensionArray):
# TODO(ExtensionIndex): remove special-case, just use self._values
return self._values.astype(object)
jbrockmendel marked this conversation as resolved.
Show resolved Hide resolved
return vals

def _from_join_target(self, result: np.ndarray) -> ArrayLike:
Expand Down