Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: droplevel copy keyword #48117

Closed

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added this to the 1.5 milestone Aug 18, 2022
@mroeschke mroeschke added the Deprecate Functionality to remove in pandas label Aug 18, 2022
@mroeschke
Copy link
Member

One merge conflict otherwise LGTM

@jbrockmendel
Copy link
Member Author

i think CI fail is unrelated

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrockmendel I see you did already another PR to add copy to set_axis as well. In general (and certainly if you are planning a concerted effort to add this to several methods), it would be helpful if you would create an issue for this that can be referenced, and to give some context for the proposed change.

Personally, I am not sure we should actually add those keywords right now (or we should at least have some discussion about it). I know we already have some places that have such a keyword (and in general I would like to see this used more as well). But with #46958 we are also planning to change the behaviour of that keyword.
So we would be adding a new feature that might actually change behaviour in one the next releases. And that change of behaviour is quite subtle (it's not something that we can easily deprecate about for those specific cases). I would really like to avoid that more people start to rely on the mutability of dataframes returned in such a copy=False case.

@jbrockmendel
Copy link
Member Author

opened #48141

@jorisvandenbossche
Copy link
Member

Thanks for opening the issue!

@mroeschke mroeschke removed this from the 1.5 milestone Aug 22, 2022
@jbrockmendel jbrockmendel deleted the perf-droplevel-copy branch September 14, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants